-
-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of COALESCE from dashboard chart #1306
Remove usage of COALESCE from dashboard chart #1306
Conversation
bananatron
commented
Mar 29, 2024
- Fixes PG::SyntaxError: ERROR from timestamp #1305 which may actually be a non-issue.
- The verbosity may not be worth the advantage given the reproducibility of this issue.
This is lovely! Any chance you could try putting the entire COALESCE into Arel? |
a8d93c5
to
f9400d1
Compare
@bensheldon I almost never use Arel so lmk if this is better/worse. |
Sorry, I missed entirely that the Arel was then getting I'm still unsure of why those spaces got inserted into the SQL previously. I'll accept this and maybe someday it will be fully Arel-ized. |
@bensheldon I am also unsure :[ but my theory is some weird level rails dependency issue 🤷 |
This is coming back with a bundler update, I wonder if the ruby version is somehow involved 🤔
Rails 7.1.3.2 This PR still seems to fix the issue fwiw. |
# Conflicts: # app/charts/good_job/scheduled_by_queue_chart.rb